[SE-4391] Cherry-pick celery fixes on Koa#27629
Merged
nedbat merged 1 commit intoopenedx:open-release/koa.masterfrom May 18, 2021
Merged
[SE-4391] Cherry-pick celery fixes on Koa#27629nedbat merged 1 commit intoopenedx:open-release/koa.masterfrom
nedbat merged 1 commit intoopenedx:open-release/koa.masterfrom
Conversation
* Update celery routing - Used routing function instead of class - Move task queues dictionary to Django settings - Removed routing_key parameter - Refactored routing for singleton celery instantiation Co-authored-by: Awais Qureshi <awais.qureshi@arbisoft.com>
openedx-webhooks
added
needs triage
open-source-contribution
|
Thanks for the pull request, @gabor-boros! I've created OSPR-5782 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Contributor
|
Thanks, looks like a faithful cherry-pick. |
|
@gabor-boros 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Contributor
|
@gabor-boros @nedbat Thank you both. |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request cherry-picks the celery fixes introduced in #25567. The discussion of the original PR contains a comment about cherry-picking the fixes, though the cherry-pick did not happen.
Co-authored-by: Awais Qureshi awais.qureshi@arbisoft.com
Discussions: https://github.com/edx/edx-platform/pull/25567#issuecomment-726482291
Dependencies: None
Screenshots: N/A
Sandbox URL: TBD - sandbox is being provisioned.
Merge deadline: ASAP
Testing instructions:
TBD
Author notes and concerns:
N/A
Reviewers
Settings